Add Rust runtime lock settings#1996
Conversation
Expose typed model and context-tier locks on create and resume session configs and serialize them through the nested runtimeSettings wire payload. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: a93a18e3-4a6d-4667-97fe-9252838f19cf
There was a problem hiding this comment.
Pull request overview
Adds typed Rust runtime lock settings and forwards them through session create/resume payloads.
Changes:
- Adds
RuntimeSettingswith model and context-tier locks. - Integrates settings into create/resume configs and wire serialization.
- Tests serialization and omission when absent.
Show a summary per file
| File | Description |
|---|---|
rust/src/types.rs |
Defines the public API, builders, forwarding, and tests. |
rust/src/wire.rs |
Adds runtime settings to create/resume wire payloads. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Medium
roji
left a comment
roji
left a comment
There was a problem hiding this comment.
This doesn't seem to be actually supported in the runtime; so while this PR adds the SDK surface and serialization, it won't actually do anything.
In general, locking settings such as the model/context tier seems like something that needs to be handled in the hosting application rather than in the runtime. For example, a UI using the SDK can block the model picker in whatever way it wants. Can you provide some context/justification for actually having a feature like this in the runtime?
Finally, note that changes in the SDK generally need to be done across all languages, not just in a single one (Rust).
Summary
RuntimeSettingsAPI with optional model and context-tier locksruntimeSettings.modelLockandruntimeSettings.contextTierLockon session create and resumeTesting
cargo +nightly-2026-04-14 fmt --checkcargo clippy --all-features --all-targets -- -D warningscargo test runtime_settings --all-features